New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If zsync eats dirt during an OTA update, allow to fallback to a full download #4438

Merged
merged 5 commits into from Jan 1, 2019

Conversation

Projects
None yet
2 participants
@NiLuJe
Copy link
Member

NiLuJe commented Dec 31, 2018

Fix #4429 (and by "fix", I mean "workaround' ;p).

Basically gives the user another choice on failure, one that'll download the full OTA package.
Prevents leaving users in the lurch in case zsync goes wonky again, like in #4429 ;).

@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Dec 31, 2018

Last PR of 2018 \o/

Show resolved Hide resolved frontend/ui/otamanager.lua Outdated
Update frontend/ui/otamanager.lua
👍

Co-Authored-By: NiLuJe <ninuje@gmail.com>
@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Jan 1, 2019

And before I forget once again, the reasoning behind leaving the FBInk strings untranslated:

The default font doesn't have a terribly wide coverage (Latin & Greek, basically), which is problematic.
Making it i18n friendly would imply switching to using our own fallback TTF font, and I'd probably want to do that in pure Lua via FFI because the overhead would be much lower this way for that codepath.
But we'd still need the standalone fbink binary for the startup scripts, which are already untranslated/untranslateable, which means that to handle that & TTF fonts & FFI, we'd need to switch to a full & dynamically linked FBInk build.

TL;DR: Meh.

@Frenzie Frenzie merged commit 92b8d70 into koreader:master Jan 1, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment