New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cre: adds in-page footnotes and alternative TOC hints tweaks #4440

Merged
merged 2 commits into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@poire-z
Copy link
Contributor

poire-z commented Jan 1, 2019

Adds 2 tweaks to allow displaying footnotes at the bottom of pages, like it's done in some printed books. This will work only with books with correctly specified footnotes with the adequate EPUB attributes, and with Wikipedia EPUBs. But users may be able to activate them for other books with some user style tweaks.
Details and some sample pages screenshots in koreader/crengine#249

image
Not sure if we should keep the .footnote, .note, .note1 extra, it might be wrong with some books, but it adds a bit of documentation on how one could do that in his user style tweaks.

Adds a few tweaks to control the build of the alternative TOC, and a bit of documentation about this alternative TOC feature.
It's a bit crowded with what looks like quite not useful tweaks, but when you get a crappy EPUB you're gonna spend a few days or weeks with, all these could be helpful.
With some user style tweaks, one may be able to build a usable TOC for some badly formatted or converted books.

image
image
image

One can also make footnote popups works in books where they would not be detected, or where there would be too many false detection, with a specific user style tweak:
image

Will need a crengine and a (small) base bumps.

Also fixes 2 paragraphs tweaks (see #4358 (comment)).

@AlanSP1

This comment has been minimized.

Copy link

AlanSP1 commented Jan 1, 2019

Added to wiki as new feature here: https://github.com/koreader/koreader/wiki/In-page-footnotes

In case that there needs to be more info how to use it, please add them here or there.

@Frenzie Frenzie added the enhancement label Jan 1, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Jan 1, 2019

Oh, that is very nice. :-)

Show resolved Hide resolved frontend/ui/data/css_tweaks.lua Outdated
Show resolved Hide resolved frontend/ui/data/css_tweaks.lua Outdated
Show resolved Hide resolved frontend/ui/data/css_tweaks.lua Outdated
Show resolved Hide resolved frontend/ui/data/css_tweaks.lua Outdated
Show resolved Hide resolved frontend/ui/data/css_tweaks.lua Outdated
Show resolved Hide resolved frontend/ui/data/css_tweaks.lua Outdated

poire-z and others added some commits Jan 1, 2019

cre: adds in-page footnotes and alternative TOC hints tweaks
Adds 2 tweaks to allow displaying footnotes at the bottom of pages,
like it's done in some printed books. This will work only with
books with correctly specified footnotes with the adequate EPUB
attributes, and with Wikipedia EPUBs. But users may be able to
activate them for other books with some user style tweaks.

Adds a few tweaks to control the build of the alternative TOC.
With some user style tweaks, one may be able to build a usable
TOC for some badly formatted or converted books.

Also fixes 2 paragraphs tweaks.
cre: in-page footnotes and alternative TOC: fix wording
Co-Authored-By: poire-z <poire-z@users.noreply.github.com>

@poire-z poire-z force-pushed the poire-z:cr_hint_tweaks branch from be2007e to 4237ae7 Jan 2, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Jan 2, 2019

Rebased to bump base, and I included a few other wording changes in your suggestion commit.

@Frenzie Frenzie merged commit ee673b1 into koreader:master Jan 2, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:cr_hint_tweaks branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment