New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallabag - Use JSON.encode to encode auth JSON #4449

Merged
merged 1 commit into from Jan 5, 2019

Conversation

Projects
None yet
2 participants
@jbrechtel
Copy link
Contributor

jbrechtel commented Jan 5, 2019

Previously the plugin was creating JSON by hand for authentication requests.
This would cause invalid JSON to be sent when the password contained characters
that need to be escaped (e.g. "). Using JSON.encode will result in values being
properly escaped when necessary.

Wallabag - Use JSON.encode to encode auth JSON
Previously the plugin was creating JSON by hand for authentication requests.
This would cause invalid JSON to be sent when the password contained characters
that need to be escaped (e.g. "). Using JSON.encode will result in values being
properly escaped when necessary.

@Frenzie Frenzie merged commit 3bf4db9 into koreader:master Jan 5, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Jan 5, 2019

Thanks!

@Frenzie Frenzie added the bug label Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment