New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few Kobo input tweaks #4450

Merged
merged 33 commits into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@NiLuJe
Copy link
Member

NiLuJe commented Jan 6, 2019

  • Fix the Touch input probe on Trilogy devices that depend on the touch_probe_ev_epoch_time quirk (fix #630)
  • Expose a "PageTurn button inversion" feature in the Navigation menu (for all devices with keys) (fix #4446)
  • Allow ignoring the accelerometer on the Forma (Screen > Ignore accelerometer rotation events) (fix #4451)
  • Fix SleepCover handling on the Forma (fix #4457)
  • Make isWifiOn a tiny bit more accurate (check the actual WiFi module instead of sdio_wifi_pwr)

NiLuJe added some commits Jan 6, 2019

Allow button inversion, and implement it on the Forma
This is a complete inversion (i.e., it affects Landscape in a
potentially highly stupid manner), unlike in Nickel.
Made button inversion generic
Which also allows us to make it take effect right away when toggled from
the menu
Really fix trilogy testcase?
(init'ing a "trilogy" should set it to true, then nil right before the
touch probe, because it's manually applying it).
Actually make the gsensor toggle work ;p.
And honor the setting at startup.

Fix #4451
Oohkay, I *think* I got what's going on...
Let's see if that helps...
Fuck it. Re-order tests.
And watch the swap_xy test being the failing one, now, right?
@Frenzie
Copy link
Member

Frenzie left a comment

basically lgtm, a couple of minor comments

@@ -27,6 +27,7 @@ local Device = {
hasClipboard = no,
hasColorScreen = no,
hasBGRFrameBuffer = no,
canToggleGSensor = no,

This comment has been minimized.

@Frenzie

Frenzie Jan 6, 2019

Member

Not hasGSensor?

This comment has been minimized.

@NiLuJe

NiLuJe Jan 6, 2019

Member

The Oasis has one, but it's trickier to toggle, so I went with something different/more accurate ;)

Show resolved Hide resolved frontend/ui/elements/common_settings_menu_table.lua Outdated
Show resolved Hide resolved frontend/ui/elements/common_settings_menu_table.lua Outdated
Show resolved Hide resolved frontend/ui/elements/common_settings_menu_table.lua Outdated
Show resolved Hide resolved frontend/ui/elements/common_settings_menu_table.lua Outdated
@@ -13,14 +13,15 @@ local eink_settings_table = {
G_reader_settings:saveSetting("low_pan_rate", Screen.low_pan_rate)
end,
},
require("ui/elements/flash_ui"),
require("ui/elements/flash_keyboard"),

This comment has been minimized.

@poire-z

poire-z Jan 6, 2019

Contributor

I think these are not that eInk specific. But OK if you need to make room, as it's most probably only on eInk that one will want to disable them (even if I disabled them on my Android phone).

This comment has been minimized.

@NiLuJe

NiLuJe Jan 6, 2019

Member

Yeah, I mainly wanted it to be near the "avoid mandatory black flashes" one, even if they're not technically eInk-specific ;).

This comment has been minimized.

@NiLuJe

NiLuJe Jan 6, 2019

Member

The fact that the eInk submenu is never hidden anywhere cinched the deal ;).

NiLuJe added some commits Jan 6, 2019

Address review comments
User-facing: hide instead of grey-out unsupported menu entries ;).
This wasn't actually generic ;).
Move it to a per-platform overload.
Don't mistake KEY_REPEAT for KEY_RELEASE as far as the SleepCover is
concerned.

The Forma has software auto-repeat enabled, and that applies to the
SleepCover "key", too.

Should help re #4457
@pazos

This comment has been minimized.

Copy link

pazos commented on frontend/device/kobo/device.lua in e2d849a Jan 7, 2019

then?

NiLuJe added some commits Jan 7, 2019

-_-"
We've got something better than luacheck: @pazos :D
Make isWifiOn more accurate on Kobo
Because for some reason, I've seomtimes seen sdio_wifi_pwr being loaded,
but not the actual WiFi driver...
@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Jan 8, 2019

I have no idea why Travis gets triggered all of a sudden?

@NiLuJe NiLuJe merged commit d113cb9 into koreader:master Jan 8, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment