New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style tweaks: split in-page footnotes tweaks #4454

Merged
merged 2 commits into from Jan 6, 2019

Conversation

Projects
None yet
2 participants
@poire-z
Copy link
Contributor

poire-z commented Jan 6, 2019

Bump crengine, includes koreader/crengine#250

  • CSS: avoid publisher's !important from overriding ours (see #4196 (comment))
  • In-page footnotes: fix vertical position when full status bar (closes #4444)
  • In-page footnotes: avoid duplicated footnotes on same page
  • In-page footnotes: fix ignored link in nested tags
  • In-page footnotes: gather links in table cells
  • In-page footnotes: fix page splitting edge cases

Split the In-page footnotes tweak into 3 distinct ones, mainly because I want the 3rd one with classic class names to be disabled'able, while keeping the others, in case these classic class names are not used for footnotes.

image
image

image
image
image

Rewording suggestions welcome.

Also fix footnotes list-style-type in Wikipedia EPUBs, which may have been wrong (but it was less visibile when following page links because of the little black marker, or showing them in popup footnotes where the number/letter is not shown).
The indeed can be specified like this:
image
And this allows the different numbering to be displayed correctly:
image

There are also pages that specifiy it differently (for footnotes numbered a,b,c..), which work in the web pages, but unfortunatly styles seem broken in the API returned HTML, so we get:
image
Nothing we can do till wikipedia fixes their stuff (https://en.wikipedia.org/wiki/Help:Footnotes#Footnotes:_predefined_groups https://phabricator.wikimedia.org/T198021)

@poire-z poire-z changed the title Style tweaks: split in-page foornote tweaks Style tweaks: split in-page footnote tweaks Jan 6, 2019

@poire-z poire-z changed the title Style tweaks: split in-page footnote tweaks Style tweaks: split in-page footnotes tweaks Jan 6, 2019

title = _("In-page classic footnotes"),
description = _([[
Show footnotes with classic class names at the bottom of pages.
This tweak can be duplicated as a user style tweak when books have footnotes wrapped with other class names.]]),

This comment has been minimized.

@Frenzie

Frenzie Jan 6, 2019

Member

Maybe something like this?

Suggested change Beta
This tweak can be duplicated as a user style tweak when books have footnotes wrapped with other class names.]]),
This tweak can be duplicated as a user style tweak when books contain footnotes indicated by other class names.]]),
-- usually random across books).
{
id = "footnote-inpage_classic_classnames";
title = _("In-page classic footnotes"),

This comment has been minimized.

@Frenzie

Frenzie Jan 6, 2019

Member

I think Classic in-page footnotes would sound better.

This comment has been minimized.

@poire-z

poire-z Jan 6, 2019

Contributor

Not really better to me. It would sound like classic in-page as an alternative to the previous sets.

I'd like to mean "Classic class names", and keep them all starting with "In-page".
May be a longer In-page classic class names footnotes or In-page usual class names footnotes ? :|

This comment has been minimized.

@Frenzie

Frenzie Jan 6, 2019

Member

In-page classic classname footnotes then I'd say, or just leave it.

This comment has been minimized.

@poire-z

poire-z Jan 6, 2019

Contributor

In-page classic classname footnotes sounds fine! Thanks.

},
{
id = "footnote-inpage_classic_classnames_smaller";
title = _("In-page classic footnotes (smaller)"),

This comment has been minimized.

@Frenzie

Frenzie Jan 6, 2019

Member

same as above

title = _("In-page classic footnotes (smaller)"),
description = _([[
Show footnotes with classic class names at the bottom of pages.
This tweak can be duplicated as a user style tweak when books have footnotes wrapped with other class names.]]),

This comment has been minimized.

@Frenzie

Frenzie Jan 6, 2019

Member

same as above

@poire-z poire-z force-pushed the poire-z:tweak_inpage_tweaks branch from 727733e to 0f14d70 Jan 6, 2019

poire-z added some commits Jan 6, 2019

Style tweaks: split in-page footnote tweaks
Split the In-page footnotes tweak into 3 distinct ones,
mainly because I want the 3rd one with classic class names
to be disabled'able, while keeping the others, in case
these classic class names are not used for footnotes.

Also fix footnotes list-style-type in Wikipedia EPUBs,
which may have been wrong (but it was less noticable when
following page links because of the little black marker,
or showing them in popup footnotes where the number/letter
is not shown).
bump crengine: in-page footnotes fixes + CSS !important tweak
Includes:
- CSS: avoid publisher's !important from overriding ours
- In-page footnotes: fix vertical position when full status bar
- In-page footnotes: avoid duplicated footnotes on same page
- In-page footnotes: fix ignored link in nested tags
- In-page footnotes: gather links in table cells
- In-page footnotes: fix page splitting edge cases

@poire-z poire-z force-pushed the poire-z:tweak_inpage_tweaks branch from 0f14d70 to d8b85f2 Jan 6, 2019

@poire-z poire-z merged commit 05f7e25 into koreader:master Jan 6, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:tweak_inpage_tweaks branch Jan 6, 2019

@Frenzie Frenzie referenced this pull request Jan 7, 2019

Closed

footer font #4458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment