New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] PocketBook 626 new firmware with new codename #4474

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Jan 11, 2019

Might need to be repeated for the others?

Fixes #4473.

[fix] PocketBook 626 new firmware with new codename
Might need to be repeated for the others?

Fixes #4473.
@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Jan 11, 2019

Might need to be repeated for the others?

Guess so. Most of the PocketBook 6xx were added in 2017, the PB6xx in 2018, and the rule seems simple and logical, so no shame doing that even if no report of such codenames really existing I think.

@Frenzie Frenzie merged commit 2cb4be7 into koreader:master Jan 13, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:pocketbook branch Jan 13, 2019

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Jan 13, 2019

I'll just keep it like this for the moment, but if another one pops up we should just add them all as a precaution. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment