Assorted minor tweaks

[NiLuJe]

• WiFi handling on Kindle (fix #4472)
• Crappy attempt at handling key repeat for the Forma pageturn buttons
• Fix long-standing OTA inconsistencies on Kindle so that OTAManager picks the right binaries (Massive oversight on my part there -_-") (re #4497).
  • Use the proper binaries (kindle5 -> kindle) on the K4
  • Use the proper binaries (kindlepw2) on every Kindle since the PW2.

[NiLuJe]

As mentioned in the code, key repeat is, err, fairly crappy :D.

Ideally, we'd queue every repeat events, and simply flush the queue on release.

Unfortunately, I have no idea how to do that (and if we even can with the current Event framework) ;).

[NiLuJe]

(Will squash manually for a rebase merge, as the two things have nothing in common).

[pazos]

@NiLuJe: not sure if I understand handling key repeat for the Forma pageturn buttons. Do you want to avoid them or to react to them as key press/release?

[pazos]

function Input:keyRepeatAsPress(ev)
    if ev.type == EV_KEY and ev.value == EVENT_VALUE_KEY_REPEAT then
        if ev.code == "LPgBack" -- replace strings with constants (int)
          or ev.code == "RPgBack"
          or ev.code == "LPgFwd"
          or ev.code == "RPgFwd" then
            ev.value = 1
        end
    end
end

[NiLuJe]

@pazos: This reacts to them, and treats them as KeyPress, as long as that's coming from a pageturn button. All other repeats are ignored.

I created the KeyRepeat event mainly because it might come in handy later, but right now, this behaves exactly as if the event sent was a KeyPress one, since the onKeyRepeat handler is just a copy of onKeyPress.

[pazos]

This reacts to them, and treats them as KeyPress, as long as that's coming from a pageturn button. All other repeats are ignored.

ok, updated the example. It can be installed as an event hook for kobos.

Imo it is better to have specific hooks because it is easier to understand them and they can be repurposed for other devices in the future.

[Frenzie]

lgtm even if parts are a bit inelegant ;-)

[Frenzie]

lgtm even if parts are a bit inelegant ;-)

[NiLuJe]

@pazos:

I'd tend to agree with you in theory, except here:

• It's generic enough to make sense in the common code. Only the crappy staggering bit is potentially device-specific, and I'm already not happy with it ;).
• I'd really like to keep a separate KeyRelease event, because ideally I would actually like to handle it differently than a Press: namely, making repeat pageturn force A2 refresh mode, while a release after a string of repeat would be a forced flashing GC16.