Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSet actual model names on PB devices #4479
Conversation
NiLuJe
added some commits
Jan 13, 2019
Frenzie
approved these changes
Jan 13, 2019
This comment has been minimized.
This comment has been minimized.
|
Is it safe to bump base (with koreader/koreader-base@4b05da6) without #4471? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Okay, I'll bake it in to pickup the pb fb fix then, thanks ;). |
NiLuJe
merged commit c327069
into
koreader:master
Jan 13, 2019
1 check passed
ci/circleci
Your tests passed on CircleCI!
Details
NiLuJe
referenced this pull request
Jan 14, 2019
Closed
PB625 When running on the screen only interference. #4476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
NiLuJe commentedJan 13, 2019
Not that we ever use it anywhere on PB, it basically just makes logs prettier ;).