New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set actual model names on PB devices #4479

Merged
merged 4 commits into from Jan 13, 2019

Conversation

Projects
None yet
2 participants
@NiLuJe
Copy link
Member

NiLuJe commented Jan 13, 2019

Not that we ever use it anywhere on PB, it basically just makes logs prettier ;).

NiLuJe added some commits Jan 13, 2019

Clear up the 630 vs. 631 snafu
Possibly marketing name quirk between different regions?
@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Jan 13, 2019

Is it safe to bump base (with koreader/koreader-base@4b05da6) without #4471?

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Jan 13, 2019

Yeah, since I updated the Docker image for nightly builds to r15c a few days ago it's completely safe. #4471 is basically just a personal reminder by @pazos to deprecate a few things in luajit-launcher.

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Jan 13, 2019

Okay, I'll bake it in to pickup the pb fb fix then, thanks ;).

@NiLuJe NiLuJe merged commit c327069 into koreader:master Jan 13, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment