Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbump crengine: Harfbuzz light, WTF-8, corrupted ZIPs #4483
Conversation
poire-z
added some commits
Jan 15, 2019
poire-z
merged commit 1928007
into
koreader:master
Jan 15, 2019
1 check passed
ci/circleci
Your tests passed on CircleCI!
Details
poire-z
deleted the
poire-z:bump_crengine
branch
Jan 15, 2019
poire-z
referenced this pull request
Feb 11, 2019
Open
[WIP] decouple render core & hardware from UI #4580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
poire-z commentedJan 15, 2019
Includes from koreader/crengine#252 & koreader/crengine#251 :
Includes koreader/koreader-base#794
utf8charcode()
for 4-bytes UTF-8 chars (text selection from book would be truncated to the first 4-bytes char met).Adds Harfbuzz light kerning methods as the 3rd toggle.
(Not yet set as a new default instead of Freetype, let's use that new one for a while to be sure it's really good and deserves to be the default.)
Also:
Small fixes to widths computation for a more balanced layout.
Decreased min width of names (on the left) from 33% to 25%, to allow more room for toggles on the right.
(May make things a little bit too stretched out with english, but should help with other languages that use longer words to name things than english.)
Also ignore disabled option names in the names width calculation (noticable on the PDF right most config menu, where toggles were uneededly too small)
I had to reduce the width of my emulator in the following screenshots, to not show super wide sausages... Looks better on my GloHD... If there's a need for tuning that, we can raise the 25% in
default_name_align_right = math.max(default_name_align_right, 0.25)
and change the padding on the left/middle/rightdefault_option_hpadding = Size.padding.fullscreen
When no height= provided, and the InfoMessage would overflow screen heigh when some long message is provided, decrease the font size until the widget fit.
(screenshot of my emulator with its height resized down)