New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic support for android eink refreshes on some rockchip devices #4517

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@pazos
Copy link
Contributor

pazos commented Jan 26, 2019

Supported devices:

  • Boyue T61 and some clones
  • Boyue T62 and some clones
  • Onyx C67
  • Energy Sistem (which are in fact Boyue T62 clones). Was tested on a energy pro 4.

Others may work with the same controller too, but are disabled by default.

Requires koreader/koreader-base#798
Requires koreader/android-luajit-launcher#96

Fixes #4373
Fixes #1613 (supported devices will show the "full refresh rate" option under eink settings. Others won't)

Related #4228 (need to add support for this specific device to work)

@pazos

This comment has been minimized.

Copy link
Contributor Author

pazos commented Jan 26, 2019

Oh well, I forgot sony-prstux 😢

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Jan 26, 2019

No comments, other than your own. ;-)

@pazos pazos force-pushed the pazos:android-eink branch from c314ad4 to 9890bd2 Jan 29, 2019

@pazos pazos requested a review from Frenzie Jan 29, 2019

@@ -25,6 +25,7 @@ local Device = {
hasFrontlight = no,
needsTouchScreenProbe = no,
hasClipboard = yes, -- generic internal clipboard on all devices
hasEinkScreen = no,

This comment has been minimized.

@Frenzie

Frenzie Jan 29, 2019

Member

Interesting default, btw.

This comment has been minimized.

@NiLuJe

NiLuJe Jan 29, 2019

Member

Is something like generic: yes; android fallback: no a viable alternative?

This comment has been minimized.

@pazos

pazos Jan 29, 2019

Author Contributor

yes, android.isEink() will return false until the device is added to a list of known supported devices. So yes for generic, android.isEink() for android, no for generic sdl and yes for the emulator?

This comment has been minimized.

@Frenzie

Frenzie Jan 30, 2019

Member

Sounds good to me.

Frenzie added a commit to Frenzie/koreader that referenced this pull request Jan 30, 2019

[Android] Bump base & luajit-launcher for basic E Ink refresh support
Prerequisite for koreader#4517.

* Add basic support for RK30xx eink devices koreader/android-luajit-launcher#96
* Add basic support for full eink updates koreader/koreader-base#798

Frenzie added a commit that referenced this pull request Jan 30, 2019

[Android] Bump base & luajit-launcher for basic E Ink refresh support (
…#4529)

Prerequisite for #4517.

* Add basic support for RK30xx eink devices koreader/android-luajit-launcher#96
* Add basic support for full eink updates koreader/koreader-base#798

@pazos pazos force-pushed the pazos:android-eink branch from 9890bd2 to bc8542d Jan 30, 2019

@Frenzie Frenzie merged commit 19d13b1 into koreader:master Feb 1, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Feb 1, 2019

Thanks for making this possible!

@pazos pazos deleted the pazos:android-eink branch Feb 2, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Feb 2, 2019

Btw @pazos, I imagine we should also be able to use this to set hasColorScreen = no on known E Ink devices.

@Cellaris

This comment has been minimized.

Copy link

Cellaris commented Feb 5, 2019

I've been testing the screen refresh on my android e-readers (v2019.02-8-g3f41560_2019-02-04). It works on the Onyx C67 but not on the InkBook Prime HD (Boyue clone). However, the "einkTest" application does run the screen refresh. This is the information that appears when you run einkTest:

Manufacturer: ARTATECH
Brand: inkBook
Model: Prime HD
Product: Prime HD
Hardware: rk30board

@pazos

This comment has been minimized.

Copy link
Contributor Author

pazos commented Feb 5, 2019

Thanks to @Cellaris for reporting!!

I imagine we should also be able to use this to set hasColorScreen = no on known E Ink devices.

@Frenzie: yes, I think this is safe for android devices. We already support a Pocketbook with colour display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment