Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crengine: count nb of images drawn & others #4542

Merged
merged 2 commits into from Feb 3, 2019

Conversation

Projects
None yet
2 participants
@poire-z
Copy link
Contributor

poire-z commented Feb 2, 2019

Includes:

Adds Document:getDrawnImagesStatistics() to help deciding if refresh with (possibly costly) dithering should be used (on devices with HW dithering capabilities) with CreDocument: when a page contains enough images to benefit from it. See #4541 , #4541 (comment).

poire-z added some commits Feb 2, 2019

bump crengine: count nb of images drawn & others
Includes:
- Update french hyphenation pattern
- epub.css: update style for 'blockquote'
- DrawBuf: count nb of images and surface drawn

Adds Document:getDrawnImagesStatistics() to help deciding
if refresh with (possibly costly) dithering should be used
(on devices with HW dithering capabilities) with CreDocument:
when a page contains enough images to benefit from it.
@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Feb 2, 2019

That's the blockquote style?

@Frenzie Frenzie added the crengine label Feb 2, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Feb 2, 2019

Yes: less margins, longer verses, less wrapped ; often, just one word was wrapped - the 1em was enough for some to not be wrapped anymore. That's indeed many pages less, but it looked legit when I quickly browsed juliet.epub.

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Feb 3, 2019

@poire-z I uploaded all the assets & set the OTA update to the new stable, so we can start merging new stuff. ;-)

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Feb 3, 2019

(The month of commercial love bears - got stuck a few minutes googling about gigolo grizzlys ... before realizing it was a verb :)

@poire-z poire-z merged commit f2a9ed0 into koreader:master Feb 3, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:bump_crengine branch Feb 3, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Feb 3, 2019

Bearing news is at least moderately common, according to COCA. Other forms like "bear news" and "bears news" slightly less so. (It doesn't look like I can link directly to search results?)

Tell your supervisor that his visitors bear news about the invasion from outer space.

Ashgrove, Claire. Immortal hope: the curse of the Templars (2012). New York : Tor,Edition: 1st ed.

The first to convert from a Templar into a knight of Azazel, the other would free with death. Merrick would not rest until he had reclaimed Fulk's soul and sent it home to the Almighty. " You go on. Take Farran with you. I am too full of aches to sit in the truck another two hours. I shall stay at the adytum tonight and meet you here in the morn. " # A frown turned the Scot's mouth into a tight line. " Mikhail ordered our return. He bears news he willna relay over the telephone. " # Merrick ground his teeth together to temper a rush of annoyance. " You may bring this news to me. I have no need to hear words of hope. I have three, mayhap four, fights left in me. Less, should you consider the toll darkness will take, once I put an end to Fulk. Tell Mikhail to send for me when he has more than words to share.

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Feb 3, 2019

Yep, no worry, bears good news is quite clear.
It all became clear when I undestood that the month of commercial love meant the month with valentine's day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.