Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
cre: allow text selection/highlighting across pages #4544
Panning to the bottom right corner (or top left corner) switches to scroll mode and scroll the page forward (resp. backward) 1/3rd of the screen.
referenced this pull request
Feb 3, 2019
I tested your recent version on my kindle and it works pretty reliably. While 1/8th of the screen is just right when it comes to width, it feels a little too much when it comes to height. On my PW3 it is 3rd line from the bottom. I wonder if we could add this as a separate setting to
I don't think it needs anything in defaults.lua. Any other area than top left/bottom right corners would feel unnatural, and the excessive width/height does not prevent anything else from working: it just happens when panning, and you're just switched temporarily into scroll mode and back, like hey, you were indeed selecting text on the 3rd line from last, ok, not on the last, but we thought about scrolling you a bit to make precise selection easier.
Feb 3, 2019
1 check passed
so I love being able to highlight text across multiple pages on my PW, thanks to the most recent nightly.
but one thing i've noticed is that if i "miss" (i..e highlight the wrong bit of text) the software goes back to previous page position.
it seems like the best user experience would be (of course I have no idea how hard to implement this would be so please take your grain of salt):
if # 2 needs to be a separate issue to track please let me know and i can open it