Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android, feat] Set APK version to a sane automated value #4546

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Feb 3, 2019

Includes "set android versionCode and android versionName at buildtime" (koreader/android-luajit-launcher#106)

  • versionCode uses the number of Git commits, because Google doesn't like values larger than 2100000000
  • versionName uses our existing version string

References #2040.

screenshot_1549212042

[Android, feat] Set APK version to a sane automated value
Includes "set android versionCode and android versionName at buildtime" (<koreader/android-luajit-launcher#106>)

* versionCode uses the number of Git commits, because Google doesn't like values larger than `2100000000`
* versionName uses our existing version string

References #2040.

@Frenzie Frenzie added the Android label Feb 3, 2019

@Frenzie Frenzie requested a review from pazos Feb 3, 2019

@pazos

pazos approved these changes Feb 3, 2019

Copy link
Contributor

pazos left a comment

Looks good, thanks!

@Frenzie Frenzie merged commit 81a2423 into koreader:master Feb 3, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:android-version branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.