Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix, AppImage] writable zsync outbox location #4568

Merged
merged 2 commits into from Feb 9, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Feb 9, 2019

It's more sensible to stick it in the designated data dir on any platform, but the AppImage (and Debian package) can't write in the program's own folders by design.

@@ -20,7 +21,7 @@ local ZSync = InputContainer:new{

function ZSync:init()
self.ui.menu:registerToMainMenu(self)
self.outbox = self.path.."/outbox"
self.outbox = DataStorage:getFullDataDir().."/outbox"

This comment has been minimized.

@Frenzie

Frenzie Feb 9, 2019

Author Member

@NiLuJe @poire-z @pazos Or maybe zsync-outbox instead of just outbox?

This comment has been minimized.

@poire-z

poire-z Feb 9, 2019

Contributor

I'm still not sure what zsync is about :| so, I dunno what ends up in that directory. But indeed, better named as the thing that put stuff in it, than a generic "output" which says nothing.

This comment has been minimized.

@Frenzie

Frenzie Feb 9, 2019

Author Member

It puts shared files there for the duration of the sharing, so that they're transferred to devices that "subscribe". It can be useful to transfer a file if you have two relatively limited devices, or just because it doesn't require configuration. (That being said, I never use it.)

This comment has been minimized.

@Frenzie

Frenzie Feb 9, 2019

Author Member

I'm not sure if it currently actually works without crashing, see #3880.

@Frenzie Frenzie merged commit e123cc5 into koreader:master Feb 9, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:zsync-appimage branch Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.