Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PicDocument: Pass a copy of image_bb in getCoverPageImage() #4628

Merged
merged 2 commits into from Feb 21, 2019

Conversation

Projects
None yet
2 participants
@NiLuJe
Copy link
Member

NiLuJe commented Feb 20, 2019

Avoids a use-after-free in mupdf.scaleBlitBuffer

Fix koreader/koreader-base#821

Thanks for the hint, @poire-z ;).

PicDocument: Pass a copy of image_bb in getCoverPageImage()
Avoids a use-after-free in mupdf.scaleBlitBuffer

Fix koreader/koreader-base#821

Thanks for the hint, @poire-z ;).
@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Feb 20, 2019

Because I mistakenly thought #4625 had been merged while it hadn't, and I just force-pushed over it as that was my master :D.

Glad that one was a one-liner, it could have been awkward... :D.

One more reason to work in topic branches ;).

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Feb 20, 2019

(Lemme try @poire-z 's suggestion before merging, though).

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Feb 20, 2019

That appears to be the right thing to do ;). Or at least it doesn't hurt ;).

@Frenzie Frenzie merged commit 6c29b7d into koreader:master Feb 21, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.