Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Gesture manager: show selected action in menu #4655

Merged
merged 3 commits into from Feb 24, 2019

Conversation

Projects
None yet
3 participants
@Frenzie
Copy link
Member

Frenzie commented Feb 24, 2019

As suggested by @poire-z (thanks for testing!)

screenshot_2019-02-24_15-36-16

PS Since #4652 it's feature complete as far as what I'd planned at the outset, other than coming up with the defaults.

@Frenzie Frenzie added the UX label Feb 24, 2019

@Frenzie Frenzie added this to the 2019.03 milestone Feb 24, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Feb 24, 2019

Tested, looking and working fine.

I would may be add some spacing between the arrows and the (action) - I used 3 spaces here.
And may be just don't show anything (keep it blank as previously) instead of (nothing) - clearer to see what's unnassigned (meaning: available, or no action).

it's feature complete as far as what I'd planned at the outset, other than coming up with the defaults.

Yep, that, and where to put this Gesture manager menu item :)

@KenMaltby

This comment has been minimized.

Copy link

KenMaltby commented Feb 24, 2019

"Available" might be a nice hint that the user could specify a function for that gesture.

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Feb 24, 2019

screenshot_2019-02-24_17-00-23

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Feb 24, 2019

Not found of (Available) as it does not really stand out of the assigned ones ((Bookmarks) has the same length). But ok, I won't visit that so often once I'm settled :)

@Frenzie Frenzie merged commit 1d6948d into koreader:master Feb 24, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:gesture-manager-show branch Feb 24, 2019

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Feb 24, 2019

@poire-z What about putting Links and Gesture manager under Navigation?

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Feb 24, 2019

Dunno. It could make sense (but there are Screen> Activate menu> which can sound like Navigation, as much as Navigation> Back key to exit).

Other ideas: Key navigation> (for the existing Navigation) and Gestures>with Activate menu>, Links>, Gesture Manager> (and Disable double tap?).

But I'd really miss the Links> at a first level submenu (may be only because I often change them for dev and testing, most users may settle on some settings and hardly go back there).

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Feb 24, 2019

I quite like the Gestures menu idea, except for the part where calling a tap a "gesture" is a bit of a stretch outside of our own technical context. It also pertains to plenty of tapping-related stuff, after all. I think the kernel speaks of Touches but that just seems weird.

Classic Opera puts the whole shebang in Shortcuts.

Some thoughts:

  • Taps & gestures
  • Language & input

Frenzie added a commit to Frenzie/koreader that referenced this pull request Feb 28, 2019

[chore, UX] Migrate Screen menu to MenuSorter & put Screensaver under…
… Screen

Doing more of this is the general purpose of MenuSorter, after all.

This is making some space for a new `Taps and gestures` menu, see <koreader#4655 (comment)>.

Frenzie added a commit that referenced this pull request Feb 28, 2019

[chore, UX] Migrate Screen menu to MenuSorter & put Screensaver under…
… Screen (#4675)

Doing more of this is the general purpose of MenuSorter, after all.

This is making some space for a new `Taps and gestures` menu, see <#4655 (comment)>.

Frenzie added a commit to Frenzie/koreader that referenced this pull request Feb 28, 2019

[UX] Introduce Taps & Gestures menu
This more logically groups together various settings related to taps and gestures.

Cf. <koreader#4655 (comment)>.

Frenzie added a commit to Frenzie/koreader that referenced this pull request Feb 28, 2019

[UX] Introduce Taps & Gestures menu
This more logically groups together various settings related to taps and gestures.

Cf. <koreader#4655 (comment)>.

Frenzie added a commit that referenced this pull request Feb 28, 2019

[UX] Introduce Taps & Gestures menu (#4677)
This more logically groups together various settings related to taps and gestures.

Cf. <#4655 (comment)>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.