Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Gesture manager: add action - go to latest bookmark #4657

Merged
merged 2 commits into from Feb 24, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Feb 24, 2019

No description provided.

@Frenzie Frenzie added the UX label Feb 24, 2019

@Frenzie Frenzie added this to the 2019.03 milestone Feb 24, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Feb 24, 2019

multiswipe_west_east = "previous_location",
multiswipe_east_west = "latest_bookmark",

Same old play of ours about gestures :| are we making a gesture or dragging the page?
For me, your choice feels unnatural - I would swap these two :|

Same thoughts I had in #4623 (comment) (and next comment) are in play too: in two swipe gestures:
A) is the first one the intention, and the second some kind of release
B) is the first one just taking some room to make the 2nd, and the second one the intention.

Your choice here would work in the mindset B. (But with north/south, for History vs Skim, I initially went with B, but A feels more natural...).

Am I making sense in my way of thinking about that? (left aside your habits with mouse gestures in browsers :)

@Frenzie Frenzie merged commit 926150d into koreader:master Feb 24, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Feb 24, 2019

Isn't there a setting somewhere to swap left/right behavior?

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Feb 24, 2019

Hey, I wasn't saying we should use what I feel natural. I'm not even sure after all this today testing :)

Does that reverse make sense for you? Or not, and that's why you asking for a swap left/right toggle?

And what about my stuff about these 2 mindsets? Any of these make more sense to you?

May be you have that habbit with east and west and browser mouse gestures, and it shows even with single swipes.
But what about north and south? What would be your natural gesture (single swipe) to bring a bigger progress bar from the bottom progress bar?
(That swap left/right toggle could be a good thing for those like you who this gesture vs dragging the way you do. But no swap north/south then?)

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Feb 24, 2019

For the record, I almost exclusively turn pages using the regular swipes. I don't particularly want to switch anything in that regard.

In any case, without this action there can't be any proper testing. Although I strongly suspect this latest change is quite horribly wrong. :-P

What would be your natural gesture (single swipe) to bring a bigger progress bar from the bottom progress bar?

Um, the one we have of course? I'm not really following the question tbh.

@Frenzie Frenzie deleted the Frenzie:gesture-manager-latest-bookmark branch Feb 24, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Feb 24, 2019

Um, the one we have of course? I'm not really following the question

I'm just trying to see what's people natural mindset related to swipes and double swipes.

The one we have (to bring the Skim widget) is hold on the footer.
As there's this thing with swipe left and right vs dragging page / doing gestures, I switched the discussion to something less left/right, just to see.)

Going to open a new issue/question and ping some people, to gather some naive opinion without all my questions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.