Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Gesture manager: add action - show frontlight dialog #4664

Merged
merged 1 commit into from Feb 26, 2019

Conversation

Projects
None yet
3 participants
@Frenzie
Copy link
Member

Frenzie commented Feb 26, 2019

Rationale for the default down, left gesture: it's pointing at the location for the frontlight toggle.

[UX] Gesture manager: add action - show frontlight dialog
Rationale for the default `down, left` gesture: it's pointing at the location for the frontlight toggle.

@Frenzie Frenzie added the UX label Feb 26, 2019

@Frenzie Frenzie added this to the 2019.03 milestone Feb 26, 2019

@gerhaher

This comment has been minimized.

Copy link

gerhaher commented Feb 26, 2019

Would it be possible to also add a natural light toggle?

@Frenzie Frenzie merged commit f8f3132 into koreader:master Feb 26, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:more-gesture-actions branch Feb 26, 2019

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Feb 26, 2019

@gerhaher The natural light toggles separately from frontlight?

@gerhaher

This comment has been minimized.

Copy link

gerhaher commented Feb 26, 2019

Yes.

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Feb 26, 2019

How do you go about toggling it precisely? (E.g., what's the text on the button?)

@gerhaher

This comment has been minimized.

Copy link

gerhaher commented Feb 26, 2019

There is no toggle button. Instead you choose the level from 0 to 100 (if you don't prefer the auto feature).

reader_2019-feb-26_094639

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Feb 26, 2019

Do you mean that this PR only brings up the regular frontlight dialog instead of the full extended dialog on supported platforms?

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Feb 26, 2019

@gerhaher No, the frontlight dialog does that all by itself. I'm afraid I don't understand what you're asking for.

@gerhaher

This comment has been minimized.

Copy link

gerhaher commented Feb 26, 2019

OK.
Never mind.

@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Feb 26, 2019

Not generally possible, as there's no notion of on or off for natural light. Both edges of the bar are the best you'll ever get, as it's quite literally a mix of color leds that depend on the frontlight's brightness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.