Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Introduce Taps & Gestures menu #4677

Merged
merged 2 commits into from Feb 28, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Feb 28, 2019

This more logically groups together various settings related to taps and gestures.

Cf. #4655 (comment).

File browser

Reader

[UX] Introduce Taps & Gestures menu
This more logically groups together various settings related to taps and gestures.

Cf. <#4655 (comment)>.

@Frenzie Frenzie added the UX label Feb 28, 2019

@Frenzie Frenzie requested a review from poire-z Feb 28, 2019

@Frenzie Frenzie added this to the 2019.03 milestone Feb 28, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Feb 28, 2019

Looks ok. (And as long there are only 9 items in gear and I can bring back Links> to it as the 10th via menusorter, I'm fine :)
Navigation to be renamed Key navigation, if it's all dependant of the device having keys?

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Feb 28, 2019

And I would move Document> (as it's mostly useless) below Taps&Gestures and Navigation, so Tap & Gestures is nearer Screen, as ... it's about screen too :)

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Feb 28, 2019

Not just physical keys though. Besides, I don't think any of that stuff should be hiding out anymore. Instead of "back key" we can make it "back action" and we can bind the whole shebang to something like left, down by default.

@Frenzie Frenzie merged commit db0467c into koreader:master Feb 28, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:taps-and-gestures-menu branch Feb 28, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Mar 2, 2019

"Disable double tap" appears twice in the Taps & gestures menu, when in File Browser (but not when in Reader).

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Mar 2, 2019

Not for me. Custom menu order issue perhaps? :-)

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Mar 2, 2019

Oh, never mind. But you need to open a book and then the filemanager for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.