Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Gesture manager: add action - toggle reflow #4688

Merged
merged 2 commits into from Mar 1, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Mar 1, 2019

Cf. #4687

@Frenzie Frenzie added the UX label Mar 1, 2019

@Frenzie Frenzie added this to the 2019.03 milestone Mar 1, 2019

self.document.configurable.text_wrap = 0
else
self.document.configurable.text_wrap = 1
end

This comment has been minimized.

@poire-z

poire-z Mar 1, 2019

Contributor

might need to check for not credocument?

This comment has been minimized.

@Frenzie

Frenzie Mar 1, 2019

Author Member

True, since otherwise you'll set (and subsequently toggle) a nonsense value and send some no-op events. It's fairly harmless otherwise. :-)

@Frenzie Frenzie merged commit 332fa64 into koreader:master Mar 1, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:action-toggle-reflow branch Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.