Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Gesture manager: add actions - prev/next chapter #4692

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
2 participants
@poire-z
Copy link
Contributor

poire-z commented Mar 1, 2019

Also adds rudimentary support for these in ReaderPaging (might need more work in some zoom modes or in scroll mode).
paper.pdf includes a workable TOC.
cf #4333 (comment)

[UX] Gesture manager: add actions - prev/next chapter
Also adds rudimentary support for these in ReaderPaging.

@poire-z poire-z referenced this pull request Mar 1, 2019

Closed

FR: more Gesture Manager actions #4333

4 of 4 tasks complete
@Frenzie

Frenzie approved these changes Mar 1, 2019

Copy link
Member

Frenzie left a comment

lgtm

@Frenzie Frenzie merged commit 1e4469f into koreader:master Mar 1, 2019

1 check failed

ci/circleci Your tests failed on CircleCI
Details

@Frenzie Frenzie added this to the 2019.03 milestone Mar 1, 2019

@Frenzie Frenzie added the UX label Mar 1, 2019

@poire-z poire-z deleted the poire-z:prev_next_chapter branch Mar 1, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Mar 1, 2019

@poire-z I don't really know why CircleCI takes a while to show up occasionally. Anyway, the readerrolling_spec file needs to be updated. I'll take care of it.

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Mar 1, 2019

Thanks :)

Frenzie added a commit to Frenzie/koreader that referenced this pull request Mar 1, 2019

Frenzie added a commit that referenced this pull request Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.