Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
ButtonProgressWidget: grey buttons instead of black #4700
May help with ghosting when closing bottom dialog, and fit better with the other grey toggles.
(To be merged or tried before/after release.)
It's actually far better in grey on my GloHD (because of the HW auto-flash, which leaves no ghosting at all):
I don't have anything against it specifically, I'll check how it looks tomorrow, but that seems benign enough ;).…
On Sat, Mar 2, 2019, 00:16 poire-z ***@***.***> wrote: Indeed. With last commit it would be: [image: image] <https://user-images.githubusercontent.com/24273478/53671686-d5fab000-3c7f-11e9-989d-38577e0ec15f.png> With one line commented out: [image: image] <https://user-images.githubusercontent.com/24273478/53671710-f165bb00-3c7f-11e9-8c5c-4b53f65a3b45.png> It might be a little busy with the grey when one have "Flash buttons and menu items", so @NiLuJe <https://github.com/NiLuJe> may put his veto (and I'll keep that to me :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4700 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG1ZpbnLU33XbDudYwA5w57dGn2PiyEks5vSbS6gaJpZM4bZ0zz> .
Mar 2, 2019
1 check passed
I'd like to add some light visual indication of which button is the default (the user default, or ours if none set).
Looks quite better on the black style than on the grey style. I'll have to check how it looks on my device.
Obviously :) Didn't think of that...