Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonProgressWidget: grey buttons instead of black #4700

Merged
merged 4 commits into from Mar 2, 2019

Conversation

Projects
None yet
3 participants
@poire-z
Copy link
Contributor

poire-z commented Mar 1, 2019

May help with ghosting when closing bottom dialog, and fit better with the other grey toggles.
See #4691 (comment) and follow ups.

(To be merged or tried before/after release.)

It's actually far better in grey on my GloHD (because of the HW auto-flash, which leaves no ghosting at all):

image

image

ButtonProgressWidget: grey buttons instead of black
May help with ghosting when closing bottom dialog,
and fit better with the other grey toggles.
@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Mar 1, 2019

Isn't there normally supposed to be some white padding in between?

(I have to say I agree with you that it seems more… blah.)

@Frenzie Frenzie added this to the 2019.04 milestone Mar 1, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Mar 1, 2019

Indeed.
With last commit it would be:

image

With one line commented out:

image

It might be a little busy with the grey when one have "Flash buttons and menu items", so @NiLuJe may put his veto (and I'll keep that to me :)

@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Mar 2, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Mar 2, 2019

Tweaked a bit to have thin grey borders, like they are on toggle switches.

New thin grey style:

image

Current default style:
image

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Mar 2, 2019

The thin gray looks nicer. :-)

@Frenzie Frenzie added the UX label Mar 2, 2019

@Frenzie

Frenzie approved these changes Mar 2, 2019

@Frenzie Frenzie merged commit 7799093 into koreader:master Mar 2, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:buttonprogresswidget branch Mar 2, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Mar 15, 2019

I'd like to add some light visual indication of which button is the default (the user default, or ours if none set).
Adding a unscaled 1px to that button border size would give:

image

image

Looks quite better on the black style than on the grey style. I'll have to check how it looks on my device.
Any other idea (keeping the widget border/invert simple - avoiding imbricating framecontainer...)

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Mar 15, 2019

Adding a unscaled 1px to that button border size would give:

Needs to be scaled of course, just use 0.5. ;-)

I'd say the border should be a different color (i.e., a darker gray or black).

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Mar 15, 2019

I'd say the border should be a different color (i.e., a darker gray or black).

Obviously :) Didn't think of that...
I'll go with the above (scaled) extra border for the now-disabled black style.
And i'll just use COLOR_BLACK for the default item with the thin grey style. It's quite discreet, may be too discreet, but I wanted it that way initially :)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.