Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] GestureDetector: add diagonal multiswipes #4704

Merged
merged 1 commit into from Mar 2, 2019

Conversation

Projects
None yet
3 participants
@Frenzie
Copy link
Member

Frenzie commented Mar 2, 2019

Multiswipes consisting of mixed straight and diagonal strokes are not dependable and too easy to mess up, but making them mutually exclusive seems to work out quite well.

[UX] GestureDetector: add diagonal multiswipes
Multiswipes consisting of mixed straight and diagonal strokes are not dependable and too easy to mess up, but making them mutually exclusive seems to work out quite well.

@Frenzie Frenzie added the UX label Mar 2, 2019

@Frenzie Frenzie added this to the 2019.03 milestone Mar 2, 2019

@Frenzie Frenzie requested a review from poire-z Mar 2, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Mar 2, 2019

Aren't we done yet with multiswipes? :)

Looks fine, and tested on my Kobo that diagonal swipe to refresh still works well.

@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Mar 2, 2019

Yay ;)

@Frenzie Frenzie merged commit ab53d79 into koreader:master Mar 2, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:gesturedetector-diagonal-multiswipes branch Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.