Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow keyboard when double tap not disabled #4711

Merged
merged 2 commits into from Mar 2, 2019

Conversation

Projects
None yet
3 participants
@poire-z
Copy link
Contributor

poire-z commented Mar 2, 2019

When double tap is not disabled (only ensured in ReaderRolling), repeated key hits were slowed down by it. This ensures Input widgets that temporarily overrides it to be disabled are satisfied.
See #4699 (comment)

Fix slow keyboard when double tap not disabled
When double tap is not disabled (only ensured in ReaderRolling),
repeated key hits were slowed down by it. This ensures
Input widgets that temporarily overrides it to be disabled
are satisfied.

@Frenzie Frenzie added this to the 2019.03 milestone Mar 2, 2019

@Frenzie Frenzie added bug UX labels Mar 2, 2019

@Frenzie Frenzie merged commit 279ffba into koreader:master Mar 2, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:double_tap_fix branch Mar 2, 2019

@ptrm

This comment has been minimized.

Copy link

ptrm commented Mar 3, 2019

I would like to ask whether this issue had been present for a longer time, or just since the recent multiswipe change? I mean, on Kobos it's hard to type more than 2-3 characters per second (by a rule of thumb), even with today's nightly containing this fix, and I'm wondering if it is something the hardware/software design is still enforcing (nickel's keyboard is faster, though)

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Mar 3, 2019

2-3 characters per second

That's already fast :)
Well, it must have been present for a long time, but only when double tap is not disabled.
May be you find it slow because of the keyboard keys flashing? You can disable that with Screen> Eink settings> Flash keyboard - which I use, and it's quite fast: I can type many keys before they are shown in the text box - and I don't seem to lose any.

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Mar 3, 2019

This issue has always been present. And I do mean always quite literally. The situation up to yesterday was introduced in 2013 (225ae9f), before which double tap delay always got in the way of tapping. Since 2013 only in certain circumstances so it went unnoticed. But since 2016 double tap has been disabled by default (3d7fe10).

I disable keyboard flashing, ftr.

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Mar 3, 2019

Btw, I don't disable it for performance reasons, just aesthetics.

2019-03-03 11.41.01.mp4.zip

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Mar 3, 2019

What is the font you are using in this video?

@ptrm

This comment has been minimized.

Copy link

ptrm commented Mar 3, 2019

I do have double tap enabled to navigate between chapters, so I did not notice the connection with slower keyboard since it has always been on :)

@Frenzie, aesthetics aside, should disabling keyboard flashing speed up the typing speed? I tried, and still faster taps are ignored, as if there was a throttle around 300ms long blocking the intermediary events

Also, what's the device, is that Kobo too?

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Mar 3, 2019

@poire-z Just standard Noto Serif?

@ptrm It shouldn't speed up typing speed perceptibly, but logically speaking less processing (in this case of where to paint updates) does of course mean faster. In a theoretical sense, not a practical one. Key flashes lag behind, registering taps does not.

I have an H2O.

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Mar 3, 2019

Just standard Noto Serif?

Oh, ok, didn't realize it was that nice... It has a bit more contrast on your video that whan can I make it.

I do have double tap enabled to navigate between chapters

Well, that double tap enabled makes every tap (turning page, opening menu...) slower.
Now that we have multiswipes, and if you can lose that habit of double taping top corners, you would gain quite something switching to gestures for next/prev chapters :)
But ok: if you disable double tap, just for testing, you still have that speed issue with the keyboard?

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Mar 3, 2019

@poire-z But shouldn't this fix make it so that the keyboard is responsive even with double tap enabled?

@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Mar 3, 2019

Yes. But what it this fix doesn't fix things enough ? :) So my question about how with it disabled.
(I just tested it on the emulator, and what I had noticed seemed fixed.)

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Mar 3, 2019

@ptrm Could you describe the specifics steps you use to get to a keyboard that is responding slowly? It could be as simple as a dialog that accidentally opens the keyboard before the dialog or something.

@ptrm

This comment has been minimized.

Copy link

ptrm commented Mar 3, 2019

Well, that double tap enabled makes every tap (turning page, opening menu...) slower.

Ah, slower despite the fix :) I just never tried to use the keyboard with double tap disabled, and since multiswipe gestures are here I will give it a try, because it appears faster indeed.

Also, I'm still not sure if I'm not tapping too lightly when typing faster, it's not a mobile phone screen after all. I will focus more on this and if it is actually an issue with KOreader will post a separate issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.