Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Gesture manager: add action - file search #4720

Merged
merged 1 commit into from Mar 3, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Mar 3, 2019

Also makes it callable from the reader.

Fixes #4717.

[UX] Gesture manager: add action - file search
Also makes it callable from the reader.

Fixes #4717.

@Frenzie Frenzie added the UX label Mar 3, 2019

@Frenzie Frenzie added this to the 2019.03 milestone Mar 3, 2019

@Frenzie Frenzie requested a review from poire-z Mar 3, 2019

@poire-z
Copy link
Contributor

poire-z left a comment

Not tested, but looks OK.

@Frenzie Frenzie merged commit 2ba480b into koreader:master Mar 3, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:gesman-action-filesearch branch Mar 3, 2019

Frenzie added a commit to Frenzie/koreader that referenced this pull request Mar 7, 2019

[fix] ReaderUI Pass self in open with cancel callback
I added a call to self in ReaderUI:showFileManager() in koreader#4720, breaking this singular reference that wasn't passing self.

Reporter on Gitter by @ptrm, see https://gitter.im/koreader/koreader?at=5c81465725e4e24c072f1a00

Frenzie added a commit that referenced this pull request Mar 7, 2019

[fix] ReaderUI Pass self in open with cancel callback (#4751)
I added a call to self in ReaderUI:showFileManager() in #4720, breaking this singular reference that wasn't passing self.

Reported on Gitter by @ptrm, see https://gitter.im/koreader/koreader?at=5c81465725e4e24c072f1a00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.