Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Gesture manager: add action - book status #4746

Merged
merged 3 commits into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Mar 6, 2019

Marking a document as "finished" is important for Wallabag (see, among others, #4737, #4271). Also it's an obvious missing action.

Default to left, up. That keeps with the fullscreen dialog gestures generally go up. Also it was still unassigned.

[UX] Gesture manager: add action - book status
Marking a document as "finished" is important for Wallabag (see, among others, #4737, #4271). Also it's an obvious missing action.

Default to left, up. That keeps with the fullscreen dialog gestures generally go up. Also it was still unassigned.

@Frenzie Frenzie added the UX label Mar 6, 2019

@Frenzie Frenzie added this to the 2019.03 milestone Mar 6, 2019

@Frenzie Frenzie requested a review from poire-z Mar 6, 2019

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Mar 6, 2019

Looks fine.
Can you please just stick in this PR the removal of the separator on the last item (wallabag), cf #4737 (review) ?

@poire-z

poire-z approved these changes Mar 6, 2019

@Frenzie Frenzie merged commit dc829d0 into koreader:master Mar 6, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:gesman-book-status branch Mar 6, 2019

@Frenzie

This comment has been minimized.

Copy link
Member Author

Frenzie commented Mar 7, 2019

I overlooked the call at the end of a document. I'll double check later if there are any more. (I quickly searched with Catfish, incorrectly apparently.)

./luajit: frontend/apps/reader/modules/readerstatus.lua:64: attempt to call method 'showStatus' (a nil value)
stack traceback:
	frontend/apps/reader/modules/readerstatus.lua:64: in function 'callback'
	frontend/ui/widget/button.lua:201: in function 'handleEvent'
	frontend/ui/widget/container/inputcontainer.lua:256: in function 'handleEvent'
	frontend/ui/widget/container/widgetcontainer.lua:88: in function 'propagateEvent'
	frontend/ui/widget/container/widgetcontainer.lua:106: in function 'handleEvent'
	frontend/ui/widget/container/widgetcontainer.lua:88: in function 'propagateEvent'
	frontend/ui/widget/container/widgetcontainer.lua:106: in function 'handleEvent'
	frontend/ui/widget/container/widgetcontainer.lua:88: in function 'propagateEvent'
	frontend/ui/widget/container/widgetcontainer.lua:106: in function 'handleEvent'
	frontend/ui/widget/container/widgetcontainer.lua:88: in function 'propagateEvent'
	frontend/ui/widget/container/widgetcontainer.lua:106: in function 'handleEvent'
	...
	frontend/ui/widget/container/widgetcontainer.lua:106: in function 'handleEvent'
	frontend/ui/widget/container/widgetcontainer.lua:88: in function 'propagateEvent'
	frontend/ui/widget/container/widgetcontainer.lua:106: in function 'handleEvent'
	frontend/ui/uimanager.lua:632: in function 'sendEvent'
	frontend/ui/uimanager.lua:153: in function '__default__'
	frontend/ui/uimanager.lua:966: in function 'handleInputEvent'
	frontend/ui/uimanager.lua:1027: in function 'handleInput'
	frontend/ui/uimanager.lua:1071: in function 'run'
	./reader.lua:224: in main chunk
	[C]: at 0x00013b61

Frenzie added a commit to Frenzie/koreader that referenced this pull request Mar 7, 2019

Frenzie added a commit that referenced this pull request Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.