Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cre: fix highlights in 2-pages mode #4753

Merged
merged 2 commits into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@poire-z
Copy link
Contributor

poire-z commented Mar 7, 2019

Also check for boxes in the 2nd page when in 2 page modes. Fix #772 (comment)
(And fix onTapXPointerSavedHighlight(), too quickly cut and pasted from drawXPointerSavedHighlight() recently in #4663).

Bump crengine and cre.cpp to correctly returns rect for the first line of the 2nd page. See koreader/koreader-base#844. Fix #772 (comment)

cre: fix highlights in 2-pages mode
Also check for boxes in the 2nd page when in 2 page modes
(and fix onTapXPointerSavedHighlight(), too quickly cut
and pasted from drawXPointerSavedHighlight() recently).
Bump crengine and cre.cpp to correctly returns rect for
the first line of the 2nd page.
@poire-z

This comment has been minimized.

Copy link
Contributor Author

poire-z commented Mar 7, 2019

(Wait for bump for koreader/koreader-base#844 to be included.)

@Frenzie

Frenzie approved these changes Mar 7, 2019

@poire-z poire-z merged commit 2c98c81 into koreader:master Mar 7, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:fix_2pages_mode_highlights branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.