Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gesture manager: allow folder shortcuts as action in Reader #4759

Merged
merged 2 commits into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Mar 8, 2019

Note that self.ui:onClose() properly closes open documents. There might be similar pieces of code around that don't do that.

Fixes #4755.

Gesture manager: allow folder shortcuts as action in Reader
Note that `self.ui:onClose()` properly closes open documents. There might be similar pieces of code around that don't do that.

Fixes #4755.

@Frenzie Frenzie added the UX label Mar 8, 2019

@Frenzie Frenzie requested a review from poire-z Mar 8, 2019

self.ui.file_chooser:changeToPath(folder)
else
local FileManager = require("apps/filemanager/filemanager")

This comment has been minimized.

@poire-z

poire-z Mar 8, 2019

Contributor

May be just add a comment for that else that in that case, we are called from the reader - that's what I suppose it's for (and remove that blank like)

This comment has been minimized.

@Frenzie

Frenzie Mar 8, 2019

Author Member

What's against the blank line? :-)

This comment has been minimized.

@poire-z

poire-z Mar 8, 2019

Contributor

What is it for? :)
(Feels like you forgot it - I use these to indicate some different logical/work/context block of code - but it feels like it's not the case there.)

This comment has been minimized.

@Frenzie

Frenzie Mar 8, 2019

Author Member

In this case a combination of legibility and the logical separation between defining the variables being used and doing stuff.

@poire-z

poire-z approved these changes Mar 8, 2019

@Frenzie Frenzie merged commit 5ccc3ec into koreader:master Mar 8, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:gesman-foldershortcuts-everywhere branch Mar 8, 2019

@Frenzie Frenzie added this to the 2019.03 milestone Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.