Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable addNote button, by letting it edit highlight #4773

Merged
merged 4 commits into from Mar 12, 2019

Conversation

Projects
None yet
3 participants
@Galunid
Copy link
Contributor

commented Mar 11, 2019

Reuses already existing highlight editing functionality, to enable "AddNote" in highlight menu. This basically does what was asked in #4115 #1095

@Frenzie Frenzie added the UX label Mar 11, 2019

galunid

@Frenzie Frenzie added this to the 2019.04 milestone Mar 12, 2019

@Frenzie
Copy link
Member

left a comment

lgtm, @poire-z any more comments?

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

None, looks good to me.

@Frenzie Frenzie merged commit 14c705f into koreader:master Mar 12, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Galunid Galunid deleted the Galunid:enable-addNote-button branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.