Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fb rotation on the Forma w/ KSM #4779

Merged
merged 13 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@NiLuJe
Copy link
Member

commented Mar 12, 2019

KSM is currently emulating a legacy pickel rotation (UR, 0), instead of what both pickel & Nickel do (CCW, 3) on the Forma.

Besides the bad interaction with FBInk described in #4752, I found out that the eInk driver was doing very weird things with A2 updates when UR @ 8bpp...

NiLuJe added some commits Mar 12, 2019

Enforce Portrait rotation on the Forma *everywhere*, KSM included.
It's currently emulating a bogus rotation, which causes issues with
FBInk, but also happens to be insidiously quirky in weird corner-cases.
@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

Pinging @ptrm, as I have no way to check if it behaves as intended on KSM ;).

NiLuJe added some commits Mar 12, 2019

...
@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

The most user-visible change as far as A2 quirks are concerned would be that FORCE_MONOCHROME will actually take now, so you won't get crappy fringes around icons when they're inverted.

Show resolved Hide resolved platform/kobo/koreader.sh Outdated

NiLuJe added some commits Mar 12, 2019

Bis
@ptrm

This comment has been minimized.

Copy link

commented Mar 13, 2019

In general, the new koreader.sh run from KSM09 works, and regardless of later orientation the touches correspond with the screen reaction. Did not have time to downgrade back to previous nightly to check if FBInk status overlay is in place, probably it will turn out tomorrow ;)

@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

@ptrm: Thanks! I assume KSM's still rotated properly when KOReader exits?

@ptrm

This comment has been minimized.

Copy link

commented Mar 13, 2019

I assume KSM's still rotated properly when KOReader exits?

That's right, and touch response is proper as well

@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

Off we go, then, thanks!

@NiLuJe NiLuJe merged commit 90df2f1 into koreader:master Mar 13, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@ptrm

This comment has been minimized.

Copy link

commented Mar 14, 2019

FTR, FBInk was oriented in portrait during OTA update syncing and unpacking today

@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

@Frenzie Frenzie added this to the 2019.04 milestone Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.