Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gesture manager] Add toggle default highlight action #4791

Merged

Conversation

Projects
None yet
3 participants
@Galunid
Copy link
Contributor

commented Mar 14, 2019

It should do what I discussed here: #4727 (comment)
@Frenzie Thanks for the instruction in the other PR ;-)
@poire-z Could you take a look?

G_reader_settings:saveSetting("default_highlight_action", next_action)
UIManager:show(InfoMessage:new{
text = _("Default highlight action changed to " .. (next_action or "default")),
timeout = 1,

This comment has been minimized.

Copy link
@poire-z

poire-z Mar 14, 2019

Contributor

And you might want to see if you'd not prefer Notification instead of InfoMessage, which makes thing less busy with rereshes. It's possible that this text is too long for a Notification, that may depends on screen dpi (haven't checked if long text is wrapped).

This comment has been minimized.

Copy link
@Galunid

Galunid Mar 14, 2019

Author Contributor

Notifications seem to work nicely and don't depend on DPI, at least on emulator, I'll test it on my kindle later and possibly amend this commit. For now everything seems to work without any problems.

galunid

@Galunid Galunid force-pushed the Galunid:gesture-manager-toggle-highlight-action branch from b8eb22d to a2fb8ba Mar 14, 2019

galunid

galunid added some commits Mar 14, 2019

galunid
@Frenzie

This comment has been minimized.

Copy link
Member

commented on 244c6e7 Mar 14, 2019

And a period. ;-)

galunid

@Frenzie Frenzie added the UX label Mar 14, 2019

@Frenzie Frenzie added this to the 2019.04 milestone Mar 14, 2019

@Frenzie Frenzie merged commit f637555 into koreader:master Mar 14, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Thanks!

@Galunid Galunid deleted the Galunid:gesture-manager-toggle-highlight-action branch Mar 14, 2019

Frenzie added a commit that referenced this pull request Mar 16, 2019

[fix, lang] ReaderGesture: toggle highlight action to cycle
I overlooked this until I noticed it on Transifex today.

See #4791 (comment)

Also changing the internal name because for something that's only been in one or two nightlies there's no point in prematurely introducing legacy settings.

Frenzie added a commit that referenced this pull request Mar 16, 2019

[fix, lang] ReaderGesture: toggle highlight action to cycle (#4809)
I overlooked this until I noticed it on Transifex today.

See #4791 (comment)

Also changing the internal name because for something that's only been in one or two nightlies there's no point in prematurely introducing legacy settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.