Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigDialog ButtonProgress: black border on default item #4805

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@poire-z
Copy link
Contributor

commented Mar 15, 2019

Make the default (user set, or KOReader's default) item among the button progress squares shown with a black border. Details in #4700 (comment) and followups.

image

ConfigDialog ButtonProgress: black border on default item
Make the default (user set, or KOReader's default) item
among the button progress squares shown with a black border.

@Frenzie Frenzie added the UX label Mar 15, 2019

@Frenzie Frenzie added this to the 2019.04 milestone Mar 15, 2019

@Frenzie
Copy link
Member

left a comment

lgtm, maybe something for a unit test? :-)

enabled = true,
width = button_width,
width = button_width - 2*extra_border_size,

This comment has been minimized.

Copy link
@Frenzie

Frenzie Mar 15, 2019

Member

No concern about height?

This comment has been minimized.

Copy link
@poire-z

poire-z Mar 15, 2019

Author Contributor

No. The height can overflow (see pic of the black style). For the width, we don't want that to keep having even dstributed squares all allong the progress bar, so we care about having the final width (inside + borders) similar.
That's for the black style we don't use :) so no worry at all for the thin grey style.

(and uh, uhnit what ? :)

@poire-z poire-z merged commit b16aa79 into koreader:master Mar 15, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:buttonprogress_default branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.