Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kindle suspend using lipc #4825

Merged
merged 4 commits into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@Galunid
Copy link
Contributor

commented Mar 20, 2019

fixes some stuff discussed in #4823

@Galunid Galunid changed the title Kindle suspend lipc Kindle suspend using lipc Mar 20, 2019

@Frenzie
Copy link
Member

left a comment

Seems fine to me

Show resolved Hide resolved frontend/apps/reader/modules/readergesture.lua Outdated
Show resolved Hide resolved frontend/ui/uimanager.lua Outdated
Show resolved Hide resolved frontend/device/kindle/powerd.lua Outdated

@Frenzie Frenzie added bug Kobo labels Mar 20, 2019

@Frenzie Frenzie added this to the 2019.04 milestone Mar 20, 2019

@Galunid

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

@Frenzie It should be labeled as Kindle, not Kobo 😉

@Frenzie Frenzie added Kindle and removed Kobo labels Mar 20, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

@Galunid I must've misclicked.

@NiLuJe
Copy link
Member

left a comment

Besides the discrepancy mentioned by @Frenzie, and the 1/0 thingy, LGTM!

Show resolved Hide resolved frontend/device/kindle/powerd.lua Outdated
Show resolved Hide resolved frontend/ui/uimanager.lua Outdated

galunid added some commits Mar 21, 2019

galunid
galunid

@Frenzie Frenzie merged commit 5f44ef5 into koreader:master Mar 21, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Galunid Galunid deleted the Galunid:kindle-suspend-lipc branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.