Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] plugins/wallabag: addArticle() method #4852

Merged
merged 2 commits into from Mar 29, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

commented Mar 29, 2019

Currently unused, but a prerequisite for dynamically adding links to Wallabag.

[feat] plugins/wallabag: addArticle() method
Currently unused, but a prerequisite for dynamically adding links to Wallabag.

@Frenzie Frenzie added the enhancement label Mar 29, 2019

@Frenzie Frenzie added this to the 2019.04 milestone Mar 29, 2019

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

Pinging @y-muller in case I missed some more elegant method of doing this.

In the short term I just want to be able to add external links to Wallabag. This is particularly salient in Wallabag articles themselves. In the longer term, the list of articles to add could additionally quite simply be stored offline, and of course since the Wallabag API immediately returns a content key it could conceivably also be rendered in a ScrollHtmlWidget. (Basically, think of the way Wikipedia content functions thanks to @poire-z but more generalized thanks to Wallabag.)

@y-muller

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

This looks good @Frenzie .
I wanted to do this but I have not found the time recently.

@Frenzie Frenzie merged commit 76fd922 into koreader:master Mar 29, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:wallabag-addarticle branch Mar 29, 2019

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

Thanks for the feedback!

It's just something I've been running into quite a lot now that I've started using Wallabag thanks to your plugin. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.