Slightly less crappy Nightmode

frontend/apps/reader/modules/readergesture.lua

@@ -703,7 +703,7 @@ function ReaderGesture:gestureAction(action, ges)
     elseif action == "toc" then
         self.ui:handleEvent(Event:new("ShowToc"))
     elseif action == "night_mode" then
-        local night_mode = G_reader_settings:readSetting("night_mode") or false
+        local night_mode = G_reader_settings:isTrue("night_mode") or false
         Screen:toggleNightMode()
         UIManager:setDirty("all", "full")
         G_reader_settings:saveSetting("night_mode", not night_mode)

frontend/device/generic/device.lua

@@ -31,6 +31,7 @@ local Device = {
     hasClipboard = yes, -- generic internal clipboard on all devices
     hasEinkScreen = yes,
     canHWDither = no,
+    canHWInvert = no,
     hasColorScreen = no,
     hasBGRFrameBuffer = no,
     canToggleGSensor = no,

frontend/device/kindle/device.lua

@@ -75,6 +75,8 @@ local Kindle = Generic:new{
     -- NOTE: We can cheat by adding a platform-specific entry here, because the only code that will check for this is here.
     isSpecialOffers = isSpecialOffers(),
     hasOTAUpdates = yes,
+    -- NOTE: HW inversion is generally safe on mxcfb Kindles
+    canHWInvert = yes,
 }
 
 function Kindle:initNetworkManager(NetworkMgr)
@@ -206,26 +208,30 @@ local Kindle2 = Kindle:new{
     hasKeyboard = yes,
     hasKeys = yes,
     hasDPad = yes,
+    canHWInvert = no,
 }
 
 local KindleDXG = Kindle:new{
     model = "KindleDXG",
     hasKeyboard = yes,
     hasKeys = yes,
     hasDPad = yes,
+    canHWInvert = no,
 }
 
 local Kindle3 = Kindle:new{
     model = "Kindle3",
     hasKeyboard = yes,
     hasKeys = yes,
     hasDPad = yes,
+    canHWInvert = no,
 }
 
 local Kindle4 = Kindle:new{
     model = "Kindle4",
     hasKeys = yes,
     hasDPad = yes,
+    canHWInvert = no,
 }
 
 local KindleTouch = Kindle:new{

frontend/device/kobo/device.lua

@@ -38,6 +38,8 @@ local Kobo = Generic:new{
     internal_storage_mount_point = "/mnt/onboard/",
     -- currently only the Aura One and Forma have coloured frontlights
     hasNaturalLight = no,
+    -- HW inversion is generally safe on Kobo, except on a few baords/kernels
+    canHWInvert = yes,
 }
 
 -- TODO: hasKeys for some devices?
@@ -114,6 +116,8 @@ local KoboPhoenix = Kobo:new{
     display_dpi = 212,
     -- the bezel covers 12 pixels at the bottom:
     viewport = Geom:new{x=0, y=0, w=758, h=1012},
+    -- NOTE: May have a buggy kernel, according to the nightmode hack...
+    canHWInvert = no,
 }
 
 -- Kobo Aura H2O2:

frontend/ui/elements/common_settings_menu_table.lua

@@ -114,15 +114,18 @@ if Device:isKobo() then
         end,
         callback = function()
             G_reader_settings:flipNilOrFalse("ignore_power_sleepcover")
+            UIManager:show(InfoMessage:new{
+                text = _("This will take effect on next restart."),
+            })
         end
     }
 end
 
 common_settings.night_mode = {
     text = _("Night mode"),
-    checked_func = function() return G_reader_settings:readSetting("night_mode") end,
+    checked_func = function() return G_reader_settings:isTrue("night_mode") end,
     callback = function()
-        local night_mode = G_reader_settings:readSetting("night_mode") or false
+        local night_mode = G_reader_settings:isTrue("night_mode") or false
         Screen:toggleNightMode()
         UIManager:setDirty(nil, "full")
         G_reader_settings:saveSetting("night_mode", not night_mode)

reader.lua

@@ -170,7 +170,7 @@ elseif not QuickStart:isShown() then
     last_file = QuickStart:getQuickStart()
 end
 -- night mode
-if G_reader_settings:readSetting("night_mode") then
+if G_reader_settings:isTrue("night_mode") then
     Device.screen:toggleNightMode()
 end