Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Add keyboard swipes #4884

Merged
merged 6 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@Frenzie
Copy link
Member

commented Apr 8, 2019

Only the e has a few swipes in this initial commit.

Screenshot of west, northwest, north, northeast, east.
Screenshot_2019-04-08_18-14-05

[UX] Add keyboard swipes
Only the `e` has a few swipes in this initial commit.

@Frenzie Frenzie added the UX label Apr 8, 2019

@Frenzie Frenzie added this to the 2019.05 milestone Apr 8, 2019

@Frenzie Frenzie requested a review from poire-z Apr 8, 2019

@poire-z
Copy link
Contributor

left a comment

Looks good and simple :)

Show resolved Hide resolved frontend/ui/data/keyboardlayouts/std.lua Outdated
Show resolved Hide resolved frontend/ui/widget/virtualkeyboard.lua Outdated
@poire-z

poire-z approved these changes Apr 9, 2019

expand symbols
The ė and ē are Baltic (Latvian, Lithuanian); not really sure how to best display them.
@poire-z

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

(And for a next PR, a little overlay widget that would show onHold, a 3x3 grid with the chars we'd get with a swipe in these 9 directions ? :)

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

@poire-z I was actually thinking of ideally doing a little bit more than that, see my latest commit.

local _e_ = {
    -- default
    "e",
    -- quick swipes
    north = "ë",
    northeast = "é",
    northwest = "è",
    east = "ê",
    west = "",
    south = "ę",
    southeast = "",
    southwest = "ė",
    -- extended hold characters, more than 3 probably not obvious
    "ē",
}

That could look something like this:

Screenshot_2019-04-09_10-34-43

But GUI is much harder. :-)

@Frenzie Frenzie merged commit 2760b98 into koreader:master Apr 9, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:keyboard-swipes branch Apr 9, 2019

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

@poire-z This actually went much quicker than I anticipated. It's almost fully functional (e.g., won't disappear yet :-P), other than being in a more or less random place for prototyping.

Screenshot_2019-04-09_15-46-35

@Biep

This comment has been minimized.

Copy link

commented Apr 11, 2019

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.