Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AutoWarmth state on resume #4901

Merged
merged 10 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@NiLuJe
Copy link
Member

commented Apr 11, 2019

Regression since #4871
Fix #4895

Update AutoWarmth state on resume
Regression since #4871
Fix #4895
@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

Hmm, potentially incomplete, because sysfs_light isn't in sync w/ powerd

@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

I don't use the feature, so I can't definitely say if this actually fixes the regression, but at least it doesn't crash ;p.

Hide the "Configure" button in the FL/NL widget on devices where it
won't do anything

(i.e., those w/ a NL mixer).
@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

That final commit is a bit hackish, but I really didn't feel like adding yet another has* field to device for a one-off like that.
Thoughts?

@Frenzie

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Yeah, I've faced the same dilemma a few times. This one seems reasonable enough.

@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

I might actually need it somewhere else to properly fix this on devices with a mixer, though, so, stay tuned... :).

@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

There, that should do it ;).

NiLuJe added some commits Apr 11, 2019

Make that slightly less confusing now that I'm actually doing a
setWarmth in the very way this comment was advocating not to ;p.

@Frenzie Frenzie added this to the 2019.05 milestone Apr 12, 2019

@Frenzie Frenzie added the bug label Apr 12, 2019

@Frenzie Frenzie merged commit f63ca00 into koreader:master Apr 12, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

NiLuJe added a commit that referenced this pull request Apr 15, 2019

Some FL regression fixes after #4901 (#4921)
* Make hasNaturalLight* caps safe to call without a device check. (fix #4919)
Make it clear that it's expecting the NTX implementation, though.
* Don't turn the FL on on resume if it was off on suspend
* Make sure turnOn/turnOff actually updates hw_intensity in the process where it matters, instead of just in a short lived fork ;). (fix #4923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.