Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to "UI" refreshes in the FM #4903

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@NiLuJe
Copy link
Member

commented Apr 11, 2019

Going with partial ends up being problematic on REAGL devices in a
number of different ways.

On Kindle (at least pre EPDCv2), it's slightly flickery because of the
whitespace and the boldface (I assume), probably combined with the need to make it FULL.
On Kobo, it's slow when anything else tries to queue an update (i.e.,
flashing the chevrons).
Which is a non-issue on the Forma because then it's fast when using
pageturns to navigate, but, still :D.

The obvious downside is we lose the automatic flash after n refresh,
which is potentially annoying on older, non-reagl devices.
It's not really an issue on REAGL devices, especially on EPDCv2.

Go back to "UI" refreshes in the FM
Going with partial ends up being problematic on REAGL devices in a
number of different ways.

On Kindle (at least pre EPDCv2), it's slightly flickery because of the
whitespace and the boldface.
On Kobo, it's slow when anything else tries to queue an update (i.e.,
flashing the chevrons).
Which is a non-issue on the Forma because then it's fast when using
pageturns to navigate, but, still :D.

The obvious downside is we lose the automatic flash after n refresh,
which is potentially annoying on older, non-reagl devices.
It's not really on issue on REAGL devices, especially on EPDCv2.
@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

That (very noticeable) discrepancy in latency/interactivity between using the chevrons vs. the pageturn buttons was basically driving me nuts :D. It ended up being faster on the flashing pageturn because that one was AUTO ;).

And it's genuinely slightly quirky to look at on a PW2.

@NiLuJe

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2019

AUTO might (depending on what it settles on, I guess) sometimes actually make this a tad slower than GLR16 on the Forma when you're using the buttons, but I'll gladly take it because it's now consistent, no matter how you navigate.

@Frenzie Frenzie merged commit 2a91b2b into koreader:master Apr 12, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie added this to the 2019.05 milestone Apr 12, 2019

@Frenzie Frenzie added the bug label Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.