Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow toggling CRe's new dithering & scaling #4922
Yep, I was just too lazy to invert the test ;p.…
On Sun, Apr 14, 2019, 21:09 poire-z ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In frontend/ui/widget/imagewidget.lua <#4922 (comment)>: > @@ -355,17 +356,31 @@ function ImageWidget:paintTo(bb, x, y) h = size.h } logger.dbg("blitFrom", x, y, self._offset_x, self._offset_y, size.w, size.h) + -- Figure out if we're trying to render one of our own icons... + local not_an_icon = (not self.file or (self.file and not util.stringStartsWith(self.file, "resources/"))) Isn't local is_icon = self.file and util.stringStartsWith(self.file, "resources/"))) just more readable, and below if ... and not is_icon then ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4922 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG1ZgDEnetqfvJX5KGhQGq7D03wEJvXks5vg3zegaJpZM4cux0w> .
Apr 18, 2019
1 check passed
ci/circleci Your tests passed on CircleCI!Details
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.