Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crengine: hyphenation, kerning and epub.css fixes #5043

Merged
merged 2 commits into from May 27, 2019

Conversation

Projects
None yet
2 participants
@poire-z
Copy link
Contributor

commented May 27, 2019

Includes:

bump crengine: hyphenation, kerning and epub.css fixes
Includes:
- Freetype kerning: fix possible unstable rendering
- Hyphenation: fix one-letter patterns, update French.pattern
- Hyphenation: update French.pattern
- epub.css: add style for empty-line (used on text files)

@Frenzie Frenzie added this to the 2019.06 milestone May 27, 2019

@Frenzie Frenzie added the crengine label May 27, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

commented May 27, 2019

Looks like koreader/crengine#291 may have caused some page shifting? Needs a manual double check in any case. :-)

[ RUN      ] spec/front/unit/readerrolling_spec.lua @ 200: Readerrolling module test initialization should emit PageUpdate event after book is rendered
spec/front/unit/readerrolling_spec.lua:204: Expected objects to be the same.
Passed in:
(number) 7
Expected:
(number) 6

stack traceback:
	spec/front/unit/readerrolling_spec.lua:204: in function 'handleEvent'
	frontend/ui/widget/container/widgetcontainer.lua:88: in function 'propagateEvent'
	frontend/ui/widget/container/widgetcontainer.lua:106: in function 'handleEvent'
	frontend/apps/reader/modules/readerrolling.lua:184: in function 'setupXpointer'
	frontend/apps/reader/modules/readerrolling.lua:254: in function 'handleEvent'
	frontend/ui/widget/container/widgetcontainer.lua:88: in function 'propagateEvent'
	...
	/home/ko/.luarocks/share/lua/5.1/busted/block.lua:155: in function 'execute'
	/home/ko/.luarocks/share/lua/5.1/busted/init.lua:7: in function 'executor'
	/home/ko/.luarocks/share/lua/5.1/busted/core.lua:312: in function </home/ko/.luarocks/share/lua/5.1/busted/core.lua:312>

[  FAILED  ] spec/front/unit/readerrolling_spec.lua @ 200: Readerrolling module test initialization should emit PageUpdate event after book is rendered (95.30 ms)
fix unit test
Logically revert test tweak done in 9a0728e, where we "Use epub.css
as the main default style, with all file formats", and lost
empty lines in text files
@poire-z

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

Or may be just a unit test on a text file :) that broke with #3996 where we switched to using epub.css on all formats... I guess I didn't see I was breaking text file, and assumed it was some other stuff, andjust fixed that unit test :|

@poire-z

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

In #3996:

fix unit test
sample.txt looks as fine with epub.css than with the obsoleted
txt.css (just a little more condensed, so a lower number of pages).

condensed, that was it :)

@poire-z poire-z merged commit 1657c5e into koreader:master May 27, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:bump_crengine branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.