Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste to shortcuts #5047

Merged
merged 2 commits into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

commented May 28, 2019

Adds a new paste action to folder shortcuts.

Fixes #5046.

Screenshot_2019-05-28_15-17-52

@Frenzie Frenzie added the UX label May 28, 2019

@Frenzie Frenzie added this to the 2019.06 milestone May 28, 2019

@Frenzie Frenzie changed the title Paste shortcuts Paste to shortcuts May 28, 2019

@Frenzie
Copy link
Member Author

left a comment

I should've probably mentioned it in the commit log for the [fix] empty clipboard commit, but if you copy something & paste it, it just sort of lingers around.

Although perhaps that's actually intended and only cut should get rid of it to prevent errors?

@poire-z

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Although perhaps that's actually intended and only cut should get rid of it to prevent errors?

No real opinion. Looks like Windows allows single copy & multiple pastes. I don't think it matters much on our devices where we can only copy books (or possibly, an image to the screensaver directory).

So, lgtm.

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

The problem I noticed was that if you cut & paste, you can then paste again and you'll get an error message.

Do you think it should be "Paste file" instead to make it clear what we're talking about here?

@poire-z

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

The problem I noticed was that if you cut & paste, you can then paste again and you'll get an error message.

Yeah, I got that. So you should indeed set it to nil when Paste after Cut. And if you can't detect Cut vs Copy at Paste time, fine to set it to nil in both cases (if you can detect that, well, no real opinion).

Do you think it should be "Paste file" instead to make it clear what we're talking about here?

Not especially. We don't add "file" to Cut/Copy/Paste/Delete in the file manager, and we're in a files context in this Shorcuts thingy, so I don't mind just seeing "Paste". And it would make the buttons a bit larger. An other option is to just show the large button with "Paste file" here (in a 2 rows buttondialog) only if you have something in the clipboard (instead of always showing it either enabled or disabled).

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

and we're in a files context in this Shorcuts thingy

The difference with the file manager is that "edit" and "delete" refer to folder shortcuts, not to performing actions with real files or folders.

@poire-z

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

So go with "Paste file" to kill any ambiguity. Possibly in a 2-rows buttondialog.

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

Alright, I'll probably do that tomorrow. :-)

@Frenzie Frenzie force-pushed the Frenzie:paste-shortcuts branch from f3285f1 to 14dd39a Jun 9, 2019

@Frenzie Frenzie merged commit efe2db4 into koreader:master Jun 9, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:paste-shortcuts branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.