Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor networking fixes on legacy Kindles #5059

Merged
merged 5 commits into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@NiLuJe
Copy link
Member

commented Jun 5, 2019

By having viable fallbacks when we can't open a Lua lipc handle, and by dealing with really really old busybox builds.

Fix #5058

NiLuJe added some commits Jun 5, 2019

Allow toggling WiFi & Suspend on legacy Kindles
There's no Lua, so no interaction w/ lipc over Lua possible,
but the CLI tools are available, so, use those instead ;).

Re #5058
Don't crash when disabling WiFi on legacy Kindles
Because the sysfs approach was always faceplanting with a
bad argument #2 to 'tonumber' (number expected, got string)
error :?
@Frenzie

Frenzie approved these changes Jun 5, 2019

Copy link
Member

left a comment

lgtm

@NiLuJe NiLuJe merged commit 89e002f into koreader:master Jun 5, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@Frenzie Frenzie added this to the 2019.06 milestone Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.