Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] End of document - go to file browser: swap openFileBrowser() close/open order #5062

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

commented Jun 9, 2019

Fixes #5060.

Cf.

filemanager = {
icon = "resources/icons/appbar.cabinet.files.png",
remember = false,
callback = function()
self:onTapCloseMenu()
self.ui:onClose()
self.ui:showFileManager()
end,
},
and
function ReaderUI:switchDocument(new_file)
if not new_file then return end
self:handleEvent(Event:new("CloseReaderMenu"))
self:handleEvent(Event:new("CloseConfigMenu"))
self.highlight:onClose() -- close highlight dialog if any
self:onClose()
self:showReader(new_file)
end

@Frenzie Frenzie added the bug label Jun 9, 2019

@Frenzie Frenzie added this to the 2019.06 milestone Jun 9, 2019

@poire-z

poire-z approved these changes Jun 9, 2019

@Frenzie Frenzie merged commit 7cbd56f into koreader:master Jun 9, 2019

@Frenzie Frenzie deleted the Frenzie:readerstatus-openfilebrowser branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.