Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] OPDS crash with fewer than 4 servers #5092

Merged
merged 1 commit into from Jun 25, 2019

Conversation

@Frenzie
Copy link
Member

commented Jun 25, 2019

Regression introduced in #4249.

Fixes #5091.

[fix] OPDS crash with fewer than 4 servers
Regression introduced in <#4249>.

Fixes <#5091>.

@Frenzie Frenzie added the bug label Jun 25, 2019

@Frenzie Frenzie added this to the 2019.07 milestone Jun 25, 2019

@poire-z
Copy link
Contributor

left a comment

OK, that fixes the crash.
But migrating the Internet Archive url only if it is nb 4 feels like another bug (we'd better loop thru all to find which is the internet archive one).
(Or may be just remove that migration line, must have been migrated by now?)

@Frenzie

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

But migrating the Internet Archive url only if it is nb 4 feels like another bug

Depends whether the intent is to migrate that one or to migrate that one only if it's fully default. (I'm not sure.) I have little interest in the matter even if it weren't 34°. :-P

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

I have little interest in the matter

Neither do I, so go ahead :)

@Frenzie Frenzie merged commit fca5175 into koreader:master Jun 25, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:fixopds branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.