Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust Gyro toggle #5104

Merged
merged 2 commits into from Jul 1, 2019

Conversation

@NiLuJe
Copy link
Member

commented Jun 30, 2019

Make sure it's off when we want it off, and on when we want it on.

The older racy behavior could lead to unexpected results after a quick succession of suspend/resume events.

NiLuJe added some commits Jun 30, 2019

Make toggling Gyro events more robust
Actually ask to turn it on/off depending on the setting, instead of a
blind toggle

A quick succession of suspend/resume events could otherwise leave it
in an unexpected state (i.e., off when it should have been on).
@Frenzie

Frenzie approved these changes Jul 1, 2019

Copy link
Member

left a comment

Cool :-)

@NiLuJe NiLuJe merged commit 38e7975 into koreader:master Jul 1, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.