Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try harder to find an FBInk binary on Kindle #5112

Merged
merged 5 commits into from Jul 9, 2019

Conversation

@NiLuJe
Copy link
Member

commented Jul 9, 2019

Otherwise, using the KUAL extension can get a bit tricky if KOReader has
been removed.

(Same logic as in libkh5, except we prefer our own build, and there's a
shitty eips fallback in case all hell broke loose and even libkh is
gone).

That said, if libkh is gone on a FW 5.x, you're in serious trouble :D.

Re #5110

NiLuJe added some commits Jul 9, 2019

Try harder to find an FBInk binary on Kindle
Otherwise, using the KUAL extension can get a bit tricky if KOReader has
been removed.

(Same logic as in libkh5, except we prefer our own build, and there's a
shitty eips fallback in case all hell broke loose and even libkh is
gone).

That said, if libkh is gone on a FW 5.x, you're in serious trouble :D.

Re #5110
Bundle libkohelper inside the KUAL extension, too
Severs the dependency on still having a koreader folder for it do
basically do anything
Actually, prefer libkh's binary
More likely to always be present, at least on FW 5.x

@NiLuJe NiLuJe merged commit 327933d into koreader:master Jul 9, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.