Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC: baseline align chapter name and page number, adds some style tweaks #5127

Merged
merged 2 commits into from Jul 19, 2019

Conversation

@poire-z
Copy link
Contributor

commented Jul 19, 2019

In the TOC, baseline align chapter name and page number, which makes it a bit prettier.
Before:
toc_before
After:
toc_after

Add a few style tweaks to ignore all horizontal margins only or all vertical margins only instead of all margins - and the same for paddings for books that wrongly use paddings for that effect.

poire-z added some commits Jul 19, 2019

Style tweaks: adds Ignore all vertical/horizontal margins/paddings
Provides a bit more granularity than the generic "Ignore all
publisher margins" - and allow the same for paddings for books
that wrongly use paddings for that effect.

@Frenzie Frenzie added this to the 2019.08 milestone Jul 19, 2019

@Frenzie Frenzie added the UX label Jul 19, 2019

@Frenzie
Copy link
Member

left a comment

Looks nice!

@poire-z poire-z merged commit fd5e4df into koreader:master Jul 19, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:aesthetoc_aesthetweaks branch Jul 19, 2019

Frenzie added a commit to Frenzie/koreader that referenced this pull request Jul 20, 2019

[lang] Minor CSS tweaks stylistic improvements
Pluralizing paddings like this is a bit unidiomatic, and that "all" seems a bit redundant.

Cf. <koreader#5127>.

Frenzie added a commit that referenced this pull request Jul 20, 2019

[lang] Minor CSS tweaks stylistic improvements (#5128)
Pluralizing paddings like this is a bit unidiomatic, and that "all" seems a bit redundant.

Cf. <#5127>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.