Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudstorage - Adding option to view unsupported files #5131

Merged
merged 8 commits into from Jul 21, 2019

Conversation

@robert00s
Copy link
Contributor

commented Jul 21, 2019

Option to show all files in cloudstorage also not supported by KOReader. We can also download any file.
To show all files in CS we need to enable option Show unsupported files in file manager (introducing in #5129)
Close: #5006
obraz
obraz
obraz

@robert00s robert00s changed the title Cloudstorage view unsupported Cloudstorage - view unsupported files Jul 21, 2019

@robert00s robert00s changed the title Cloudstorage - view unsupported files Cloudstorage - Adding option to view unsupported files Jul 21, 2019

@Frenzie Frenzie added this to the 2019.08 milestone Jul 21, 2019

@Frenzie
Copy link
Member

left a comment

lgtm, just a tiny nitpick. 👍

frontend/apps/cloudstorage/ftpapi.lua Outdated Show resolved Hide resolved
frontend/apps/cloudstorage/webdav.lua Outdated Show resolved Hide resolved
frontend/apps/cloudstorage/webdavapi.lua Outdated Show resolved Hide resolved

robert00s and others added some commits Jul 21, 2019

Update frontend/apps/cloudstorage/dropbox.lua
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
Update frontend/apps/cloudstorage/dropboxapi.lua
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
Update frontend/apps/cloudstorage/ftp.lua
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
Update frontend/apps/cloudstorage/ftpapi.lua
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
Update frontend/apps/cloudstorage/webdav.lua
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
Update frontend/apps/cloudstorage/webdavapi.lua
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
@robert00s

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2019

👍

@Frenzie Frenzie merged commit cbba756 into koreader:master Jul 21, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.