Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gesture intervals configurable #5138

Merged
merged 2 commits into from Jul 24, 2019

Conversation

@robert00s
Copy link
Contributor

commented Jul 23, 2019

Discussion: #4842
Close: #4842

Screenshots:

obraz

obraz

obraz

@Frenzie Frenzie added this to the 2019.08 milestone Jul 23, 2019

text = T(_([[
Set double tap interval.
Time interval is in miliseconds.
Acceptable value from 100 (0,1 sec) to 2000 (2 sec).

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jul 23, 2019

Member

I don't like "acceptable value". I'll think about it more later. :-)

This comment has been minimized.

Copy link
@NiLuJe

NiLuJe Jul 23, 2019

Member

Accepts value from if you want to keep the same verb. Otherwise, supports, handles?

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jul 23, 2019

Member

I'd make it something like this.

Set double tap interval in milliseconds.

The interval value can range from 100 (0.1 seconds) to 2000 (2 seconds).

This comment has been minimized.

Copy link
@robert00s

robert00s Jul 24, 2019

Author Contributor

Thanks :)
Changes have been made.

obraz

DOUBLE_TAP_INTERVAL = 300 * 1000,
TWO_FINGER_TAP_DURATION = 300 * 1000,
HOLD_INTERVAL = 500 * 1000,
PAN_DELAYED_INTERVAL = 500 * 1000,
SWIPE_INTERVAL = 900 * 1000,
-- all the time parameters are in us
ges_double_tap_interval = G_reader_settings:readSetting("ges_double_tap_interval") or 300 * 1000,

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jul 23, 2019

Member

I realize it's duplicated because you can't reference self.DOUBLE_TAP_INTERVAL yet but perhaps it'd be better to define them locally above first for clarity? Then it could just be or DOUBLE_TAP_INTERVAL.

This comment has been minimized.

Copy link
@robert00s

robert00s Jul 24, 2019

Author Contributor

Done.

@Frenzie Frenzie merged commit 1f6af80 into koreader:master Jul 24, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

Frenzie added a commit to Frenzie/koreader that referenced this pull request Jul 26, 2019

Frenzie added a commit that referenced this pull request Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.