Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set font size for menu items #5146

Merged
merged 3 commits into from Jul 28, 2019

Conversation

@robert00s
Copy link
Contributor

commented Jul 26, 2019

Ref: #4757
This PR add option to changing the font size of items in menu widget (filemanger in classic mode, TOC) in single line mode.
Close: #4757

obraz
obraz
obraz
obraz

@robert00s robert00s requested review from Frenzie and poire-z Jul 26, 2019

@KenMaltby

This comment has been minimized.

Copy link

commented Jul 26, 2019

Perhaps with a warning that "Changing Font Size will effect "items per page"" that and/or line spacing.

@Frenzie Frenzie added this to the 2019.08 milestone Jul 26, 2019

@Frenzie Frenzie added the UX label Jul 26, 2019

text = _("Items per page"),
help_text = _([[This sets the number of items per page in:
self.menu_items.items = {
text = _("Items"),

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jul 26, 2019

Member

Maybe something like View? But that's just a synonym for Display, already used above when CoverBrowser is enabled. Without CoverBrowser you don't get access to settings like home abbreviation? It might be necessary to give that some attention, even if not necessarily as part of this PR. Also pinging @poire-z

frontend/apps/filemanager/filemanagermenu.lua Outdated Show resolved Hide resolved
Update frontend/apps/filemanager/filemanagermenu.lua
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
callback = function(spin)
G_reader_settings:saveSetting("items_per_page", spin.value)
--after changing items per page we reset the font size of item and set it as default
G_reader_settings:saveSetting("items_font_size", math.floor(24 - ((spin.value - 6)/ 18) * 10 ))

This comment has been minimized.

Copy link
@robert00s

robert00s Jul 27, 2019

Author Contributor

After changing items per page should I change font size for default or keep settings from maximum font size for item? Now I reset font size to default.

This comment has been minimized.

Copy link
@Frenzie

Frenzie Jul 27, 2019

Member

It seems somewhat unexpected to change that when you're just changing one setting.

This comment has been minimized.

Copy link
@robert00s

robert00s Jul 27, 2019

Author Contributor

Ok, I removed it.

@Frenzie Frenzie merged commit b71d0a1 into koreader:master Jul 28, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.